cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vivek Mishra (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-2377) NPE During Repair In StreamReplyVerbHandler
Date Fri, 25 Mar 2011 09:57:06 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-2377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011146#comment-13011146
] 

Vivek Mishra commented on CASSANDRA-2377:
-----------------------------------------

I was going through the changes made. I wonder what should be the value of reply.getSessionID
for:


 StreamReply reply = StreamReply.serializer.deserialize(new DataInputStream(bufIn), message.getVersion());

Should we check for this, instead of 

if (session == null)
            {
                logger.warn("Received stream action " + reply.action + " for an unknown session
from " + message.getFrom());
                return;
         }
 
As per log it happens for :

 case SESSION_FINISHED:


So changes should be something like this:

if (SESSION_FINISHED.equals(reply.action.))
            {
                logger.warn("Received stream action " + reply.action + " for an unknown session
from " + message.getFrom());
                return;
         }


Idea is to save any additional static call on StreamOutSession.get(message.getFrom(), reply.sessionId),
which results in object instantiation for new Pair<InetAddress, Long>(host, sessionId).




> NPE During Repair In StreamReplyVerbHandler
> -------------------------------------------
>
>                 Key: CASSANDRA-2377
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2377
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.7.4
>         Environment: CentOS
>            Reporter: Benjamin Coverston
>            Assignee: Brandon Williams
>             Fix For: 0.7.5
>
>         Attachments: 2377.txt
>
>
> ERROR [MiscStage:4] 2011-03-24 02:45:05,172 DebuggableThreadPoolExecutor.java (line 103)
Error in ThreadPoolExecutorjava.lang.NullPointerException
>         at org.apache.cassandra.streaming.StreamReplyVerbHandler.doVerb(StreamReplyVerbHandler.java:62)
       at org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:72)  
     at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(Unknown Source)        at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown
Source)
>         at java.lang.Thread.run(Unknown Source)
> ERROR [MiscStage:4] 2011-03-24 02:45:05,172 AbstractCassandraDaemon.java (line 112) Fatal
exception in thread Thread[MiscStage:4,5,main]java.lang.NullPointerException
>         at org.apache.cassandra.streaming.StreamReplyVerbHandler.doVerb(StreamReplyVerbHandler.java:62)
       at org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:72)  
     at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(Unknown Source)        at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown
Source)
>         at java.lang.Thread.run(Unknown Source)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message