cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Dusbabek (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (CASSANDRA-2262) use o.a.c.marshal.*Type for CQL
Date Tue, 08 Mar 2011 21:50:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-2262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004210#comment-13004210
] 

Gary Dusbabek edited comment on CASSANDRA-2262 at 3/8/11 9:48 PM:
------------------------------------------------------------------

bq. 0006 expands TimeUUIDType.fromString to support parsing all of the CQL supported formats.
This looks good, but deserves a unit test.
+1 on the rest.

      was (Author: gdusbabek):
    bq. 0006 expands TimeUUIDType.fromString to support parsing all of the CQL supported formats.
This looks good, but deserves a unit test.
  
> use o.a.c.marshal.*Type for CQL 
> --------------------------------
>
>                 Key: CASSANDRA-2262
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2262
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: API
>    Affects Versions: 0.8
>            Reporter: Eric Evans
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.8
>
>         Attachments: v3-0001-CASSANDRA-2262-test-shows-no-roundtrip-in-BytesType.txt,
v3-0002-BytesType.fromString-expects-a-hex-string.txt, v3-0003-compose-method-for-AbstractTypes.txt,
v3-0004-assume-utf8-in-CliTest-keys-dammit.txt, v3-0005-AbstractType.fromString-throws-MarshalException.txt,
v3-0006-expand-fromString-parsing-of-TimeUUIDType.txt, v3-0007-catch-MarshalException-raise-RuntimeException.txt,
v3-0008-remove-Override-annotations.txt, v5-0006-expand-fromString-parsing-of-TimeUUIDType.txt,
v5-0007-catch-MarshalException-raise-RuntimeException.txt, v6-0001-test-shows-no-roundtrip-in-BytesType.txt,
v6-0002-BytesType.fromString-expects-a-hex-string.txt, v6-0003-compose-method-for-AbstractTypes.txt,
v6-0004-assume-utf8-in-CliTest-keys-dammit.txt, v6-0005-AbstractType.fromsString-throws-MarshalException.txt,
v6-0006-expand-fromString-parsing-of-TimeUUIDType.txt, v6-0007-catch-MarshallException-raise-RuntimeException.txt,
v6-0008-unit-test-for-TimeUUIDType.fromString.t
 xt
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Presently, {{o.a.c.cql.Term.getByteBuffer}} manage's the conversion from a parsed term
to a {{ByteBuffer}} of the right contents, this should be moved into the individual {{AbstractType}}
subclasses (aka {{AbstractType.fromString}}).
> Additionally, a method that does the inverse (returning the string equivalent), needs
to exists such that {{AbstractType.getString(AbstractType.fromString(s)) == s}}
> Finally, for use in results decoding a method should exist that given a {{ByteBuffer}}
will return the appropriate object for that type.  For example, {{IntegerType.compose(ByteBuffer)
-> java.math.BigInteger}}, or {{LexicalUUIDType.compose(ByteBuffer) -> java.util.UUID}}.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message