cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeremy Hanna (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-1263) Push replication factor down to the replication strategy
Date Tue, 29 Mar 2011 22:37:05 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-1263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012753#comment-13012753
] 

Jeremy Hanna commented on CASSANDRA-1263:
-----------------------------------------

Overall looks like a clean way of pushing down the RF to strategy.  A few minor points:

In KSMetaData it has the following:
{code}
        StringBuilder sb = new StringBuilder();
        sb.append(name)
          .append("rep factor:")
          .append("rep strategy:")
          .append(strategyClass.getSimpleName())
          .append("{")
          .append(StringUtils.join(cfMetaData.values(), ", "))
          .append("}");
        return sb.toString();
{code}
Shouldn't the rep factor String be gone along with the variable output?

The end of SimpleStrategy - the curly brace should be on its own line.

I see an instance of replication_factor in Cli.g - not sure if that matters.  Seems that's
just for typing generally.

Looks like CQL still has some references to the way things were with RF - that could be a
separate issue I would think.

> Push replication factor down to the replication strategy
> --------------------------------------------------------
>
>                 Key: CASSANDRA-1263
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1263
>             Project: Cassandra
>          Issue Type: Task
>          Components: Core
>            Reporter: Jeremy Hanna
>            Assignee: Jon Hermes
>            Priority: Minor
>             Fix For: 0.8
>
>         Attachments: 1263-2.txt, 1263-3.txt, 1263-incomplete.txt, 1263.txt
>
>   Original Estimate: 8h
>  Remaining Estimate: 8h
>
> Currently the replication factor is in the keyspace metadata.  As we've added the datacenter
shard strategy, the replication factor becomes more computed by the replication strategy.
 It seems reasonable to therefore push the replication factor for the keyspace down to the
replication strategy so that it can be handled in one place.
> This adds on the work being done in CASSANDRA-1066 since that ticket will make the replication
strategy a member variable of keyspace metadata instead of just a quasi singleton giving the
replication strategy state for each keyspace.  That makes it able to have the replication
factor.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message