cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Folke Behrens (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-2233) Add unified UUIDType
Date Thu, 03 Mar 2011 01:05:37 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001781#comment-13001781
] 

Folke Behrens commented on CASSANDRA-2233:
------------------------------------------

A few more suggestions:
- generalize the type, make it deal with all kinds of variants/versions. (http://tools.ietf.org/html/rfc4122)
- check if it makes sense to treat the Nil UUID differently (similarly to NULL in popular
SQL databases).
- don't access ByteBuffer.array() directly without asking if ByteBuffer.hasArray() first.
- write a unit test.
- format the code: http://wiki.apache.org/cassandra/CodeStyle
- check with the devs if they would prefer a patch.


> Add unified UUIDType
> --------------------
>
>                 Key: CASSANDRA-2233
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2233
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.7.3
>            Reporter: Ed Anuff
>            Priority: Minor
>         Attachments: UUIDType.java
>
>
> Unified UUIDType comparator, compares as time-based if both UUIDs are time-based, otherwise
uses byte comparison.  Based on code from the current LexicalUUIDType and TimeUUIDType comparers,
so performance and behavior should be consistent and compatible.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message