cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-2352) zero-length strings should result in zero-length ByteBuffers
Date Fri, 18 Mar 2011 13:17:29 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008423#comment-13008423
] 

Jonathan Ellis commented on CASSANDRA-2352:
-------------------------------------------

We have separate checks in ThriftValidation for name.remaining() != 0.

I'm guessing this is to make it easier to do slicing, where empty start is valid?

> zero-length strings should result in zero-length ByteBuffers
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-2352
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2352
>             Project: Cassandra
>          Issue Type: Bug
>          Components: API, Core
>            Reporter: Eric Evans
>            Assignee: Eric Evans
>              Labels: cql
>             Fix For: 0.8
>
>         Attachments: v1-0001-CASSANDRA-2352-AT.fromString-should-return-empty-BB-fo.txt
>
>
> The {{o.a.c.db.marshal.AbstractType.fromString()}} methods should return an empty {{ByteBuffer}}
when passed a zero-length string, (empty bytes do {{validate()}} properly).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message