Return-Path: Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: (qmail 86806 invoked from network); 5 Feb 2011 21:47:54 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 5 Feb 2011 21:47:54 -0000 Received: (qmail 76507 invoked by uid 500); 5 Feb 2011 21:47:54 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 76473 invoked by uid 500); 5 Feb 2011 21:47:53 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 76465 invoked by uid 99); 5 Feb 2011 21:47:53 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 05 Feb 2011 21:47:53 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 05 Feb 2011 21:47:51 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id A61A5191683 for ; Sat, 5 Feb 2011 21:47:30 +0000 (UTC) Date: Sat, 5 Feb 2011 21:47:30 +0000 (UTC) From: "Nick Bailey (JIRA)" To: commits@cassandra.apache.org Message-ID: <318724415.2120.1296942450677.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] Commented: (CASSANDRA-1427) Optimize loadbalance/move for moves within the current range MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/CASSANDRA-1427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991068#comment-12991068 ] Nick Bailey commented on CASSANDRA-1427: ---------------------------------------- * Seems like move should just fail if token is null. * Shouldn't the pending ranges calculation include the tokens the nodes are moving too as well? ** It also looks like the writeEndpoints calculation in token metadata is just a list rather than a set. So we could potentially be adding the same endpoint multiple times here. Best solution is probably to make that calculation return a set. * A MoveTest.java already exists. The fact that its still passing is probably indicative of it's usefulness but it should probably be updated and hopefully made more useful. > Optimize loadbalance/move for moves within the current range > ------------------------------------------------------------ > > Key: CASSANDRA-1427 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1427 > Project: Cassandra > Issue Type: Sub-task > Components: Core > Affects Versions: 0.7 beta 1 > Reporter: Nick Bailey > Assignee: Pavel Yaskevich > Fix For: 0.8 > > Attachments: CASSANDRA-1427-v2.patch, CASSANDRA-1427.patch > > Original Estimate: 42h > Time Spent: 42h > Remaining Estimate: 0h > > Currently our move/loadbalance operations only implement case 2 of the Ruhl algorithm described at https://issues.apache.org/jira/browse/CASSANDRA-192#action_12713079. > We should add functionality to optimize moves that take/give ranges to a node's direct neighbors. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira