Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Sat, 5 Feb 2011 02:53:30 +0000 (UTC)
From: "Matthew F. Dennis (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: 
 <253373684.1316.1296874410852.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <106097108.9023.1296778528993.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] Commented: (CASSANDRA-2107) MessageDigests are created in
 several places, centralize the creation and error handling
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12990889#comment-12990889 ] 

Matthew F. Dennis commented on CASSANDRA-2107:
----------------------------------------------

The above link is from SVN revision 2 on Sep 15, 2009 "initial code dump".  It doesn't look like MessageDigestAlgorithm (or any equivalent) exists in Guava (even in r2 despite the fact that it has javadoc for it).

> MessageDigests are created in several places, centralize the creation and error handling
> ----------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-2107
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2107
>             Project: Cassandra
>          Issue Type: Improvement
>    Affects Versions: 0.7.0
>            Reporter: Matthew F. Dennis
>            Assignee: Matthew F. Dennis
>            Priority: Minor
>             Fix For: 0.7.2
>
>         Attachments: 2107-cassandra-0.7.txt
>
>
> MessageDigest.getInstance("SomeAlg") throws NoSuchAlgorithm exception (a checked exception).  This is annoying as it causes everyone that uses standard algs like MD5 to surround their code in try/catch.  We should concentrate the creation in one method that doesn't raise an exception (i.e. catches NoSuchAlgorithm and raises a RuntimeException) just to clean the code up a little.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira