cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-2107) MessageDigests are created in several places, centralize the creation and error handling
Date Fri, 18 Feb 2011 22:52:38 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996631#comment-12996631
] 

Hudson commented on CASSANDRA-2107:
-----------------------------------

Integrated in Cassandra-0.7 #296 (See [https://hudson.apache.org/hudson/job/Cassandra-0.7/296/])
    centralize MessageDigest creation and use threadlocals for MD5s
patch by mdennis; reviewed by jbellis for CASSANDRA-2107


> MessageDigests are created in several places, centralize the creation and error handling
> ----------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-2107
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2107
>             Project: Cassandra
>          Issue Type: Improvement
>    Affects Versions: 0.7.0
>            Reporter: Matthew F. Dennis
>            Assignee: Matthew F. Dennis
>            Priority: Minor
>             Fix For: 0.7.3
>
>         Attachments: 2107-cassandra-0.7.txt
>
>
> MessageDigest.getInstance("SomeAlg") throws NoSuchAlgorithm exception (a checked exception).
 This is annoying as it causes everyone that uses standard algs like MD5 to surround their
code in try/catch.  We should concentrate the creation in one method that doesn't raise an
exception (i.e. catches NoSuchAlgorithm and raises a RuntimeException) just to clean the code
up a little.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message