cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <>
Subject [jira] Commented: (CASSANDRA-2219) modernize nodecmd option handling
Date Mon, 28 Feb 2011 09:47:37 GMT


Sylvain Lebresne commented on CASSANDRA-2219:

I think we can call the optionalKsAndCFs function in the default of the main switch, to  avoid
having to add those commands in two places.

Other that that, this looks ok. +1 minor first remark. 

It still don't feel like the most modern code we have. The help for instance is ugly, I would
prefer having a general help listing the commands and be able to do 'nodetool help compact'
for instance. But it's probably not worth rewriting all this for now unless someone gets really

> modernize nodecmd option handling
> ---------------------------------
>                 Key: CASSANDRA-2219
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>            Reporter: Jonathan Ellis
>            Assignee: Pavel Yaskevich
>            Priority: Minor
>             Fix For: 0.7.4
>         Attachments: CASSANDRA-2219.patch
>   Original Estimate: 1h
>          Time Spent: 1h
>  Remaining Estimate: 0h

This message is automatically generated by JIRA.
For more information on JIRA, see:


View raw message