cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-2158) memtable_throughput_in_mb can not support sizes over 2.2 gigs because of an integer overflow.
Date Fri, 18 Feb 2011 22:52:38 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-2158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996632#comment-12996632
] 

Hudson commented on CASSANDRA-2158:
-----------------------------------

Integrated in Cassandra-0.7 #296 (See [https://hudson.apache.org/hudson/job/Cassandra-0.7/296/])
    update memtable_throughput to be a long
patch by jbellis; reviewed by brandonwilliams for CASSANDRA-2158


> memtable_throughput_in_mb can not support sizes over 2.2 gigs because of an integer overflow.
> ---------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-2158
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2158
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Eddie
>            Assignee: Jonathan Ellis
>             Fix For: 0.7.3
>
>         Attachments: 2158.txt
>
>
> If memtable_throughput_in_mb is set past 2.2 gigs, no errors are thrown.  However, as
soon as data starts being written it is almost immediately being flushed.  Several hundred
SSTables are created in minutes.  I am almost positive that the problem is that when memtable_throughput_in_mb
is being converted into bytes the result is stored in an integer, which is overflowing.
> From memtable.java:
>     private final int THRESHOLD;
>     private final int THRESHOLD_COUNT;
> ...
> this.THRESHOLD = cfs.getMemtableThroughputInMB() * 1024 * 1024;
> this.THRESHOLD_COUNT = (int) (cfs.getMemtableOperationsInMillions() * 1024 * 1024);
> NOTE:
> I also think currentThroughput also needs to be changed from an int to a long.  I'm not
sure if it is as simple as this or if this also is used in other places.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message