Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Message-ID: <418373.168751294259146694.JavaMail.jira@thor>
Date: Wed, 5 Jan 2011 15:25:46 -0500 (EST)
From: "Kelvin Kakugawa (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Subject: [jira] Commented: (CASSANDRA-1937) Keep partitioned counters
 ("contexts") sorted
In-Reply-To: <9610925.161871294242285835.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12977953#action_12977953 ] 

Kelvin Kakugawa commented on CASSANDRA-1937:
--------------------------------------------

Definitely agree.  I made the trade-off to keep them in update order.  i.e. the order in which the node was last updated.  However, keeping them in node id sorted order did cross my mind.

> Keep partitioned counters ("contexts") sorted
> ---------------------------------------------
>
>                 Key: CASSANDRA-1937
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1937
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>             Fix For: 0.8
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> In the value of CounterColumns, the code keep the subpart unsorted, but sort
> them 'on the fly' when needed (in diff() and merge()). It will be more
> efficient to keep the parts always sorted (it will also be easier in that it
> will remove the need of the ad-hoc in-place quicksort in CounterContext).
> NOTE: this breaks the on-disk file format (for counters)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.