Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Message-ID: <25290344.34741295353065149.JavaMail.jira@thor>
Date: Tue, 18 Jan 2011 07:17:45 -0500 (EST)
From: "Sylvain Lebresne (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Subject: [jira] Updated: (CASSANDRA-1944) Support CL.QUORUM and CL.ALL for
 counter writes
In-Reply-To: <9830011.185861294313326215.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/CASSANDRA-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sylvain Lebresne updated CASSANDRA-1944:
----------------------------------------

    Attachment: 0001-Add-support-for-CL.QUORUM-and-CL.ALL-v3.patch

Attaching v3.

bq. rename WriteProtocol (WritePerformer, maybe?) and doWriteProtocol to something more descriptive

Did the rename of WriteProtocol (to WritePerformer). I did not rename doWriteProtocol because quite honestly I did not found a better name (but I think I suck at naming so if you have opinion ...). I did however add a comment desribing the function further. For that matter, I also added a comment to mutateCounters() explaining the main differences between the standard and counter write protocols.

bq. it looks like there is no per-WriteProtocol state, so we can make a singleton class each for normal mutations and for counters, to avoid that extra anonymous object creation on each write

Very good idea, done.

bq. instead of not including counter stats at all, let's add an Increments set of statistics

Actually my mistake, the counter stats were included, but are gathered in SP.mutateCounters(). Again I added comments to make that more clear. But I also created a increment specific set of statistics.


> Support CL.QUORUM and CL.ALL for counter writes 
> ------------------------------------------------
>
>                 Key: CASSANDRA-1944
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1944
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.8
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>             Fix For: 0.8
>
>         Attachments: 0001-Add-support-for-CL.QUORUM-and-CL.ALL-v2.patch, 0001-Add-support-for-CL.QUORUM-and-CL.ALL-v3.patch, 0001-Add-support-for-CL.QUORUM-and-CL.ALL.patch
>
>   Original Estimate: 16h
>  Remaining Estimate: 16h
>
> This ticket basically proposes to make the counter ReplicateOnWrite mechanism
> synchronous instead of asynchronous. This will allow to support CL.QUORUM and
> CL.ALL for counter writes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.