Return-Path: Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: (qmail 76762 invoked from network); 17 Jan 2011 19:06:09 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 17 Jan 2011 19:06:09 -0000 Received: (qmail 70801 invoked by uid 500); 17 Jan 2011 19:06:09 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 70731 invoked by uid 500); 17 Jan 2011 19:06:08 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 70723 invoked by uid 99); 17 Jan 2011 19:06:08 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Jan 2011 19:06:08 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Jan 2011 19:06:06 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id p0HJ5iXp021628 for ; Mon, 17 Jan 2011 19:05:44 GMT Message-ID: <20825700.20661295291144811.JavaMail.jira@thor> Date: Mon, 17 Jan 2011 14:05:44 -0500 (EST) From: "Sylvain Lebresne (JIRA)" To: commits@cassandra.apache.org Subject: [jira] Updated: (CASSANDRA-1998) Make offsets in ByteBufferUtil.* methods relatif to the ByteBuffer position() In-Reply-To: <7117745.17011295282750581.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/CASSANDRA-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylvain Lebresne updated CASSANDRA-1998: ---------------------------------------- Attachment: 0002-0.7-Move-EMPTY_BYTE_BUFFER-to-ByteBufferUtil.patch 0001-0.7-Make-BB-offset-relative-to-position.patch Attaching patch for 0.7 and rebased after #1999 > Make offsets in ByteBufferUtil.* methods relatif to the ByteBuffer position() > ----------------------------------------------------------------------------- > > Key: CASSANDRA-1998 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1998 > Project: Cassandra > Issue Type: Improvement > Components: Core > Affects Versions: 0.8 > Reporter: Sylvain Lebresne > Assignee: Sylvain Lebresne > Priority: Minor > Fix For: 0.8 > > Attachments: 0001-0.7-Make-BB-offset-relative-to-position.patch, 0001-Make-BB-offset-relative-to-position.patch, 0002-0.7-Move-EMPTY_BYTE_BUFFER-to-ByteBufferUtil.patch, 0002-Move-EMPTY_BYTE_BUFFER-to-ByteBufferUtil.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > A few methods in ByteBufferUtil take as parameter an offset inside a > ByteBuffer. When we use them, we always want this offset to be relative to > ByteBuffer.position(), but it is not, it is relative to the ByteBuffer 0 > position. I argue this is not inline with the way we use ByteBuffers and as a > consequence, is ugly and error-prone. > This ticket proposes to make the offset of the ByteBufferUtil.* methods > relatif to the ByteBuffer position. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.