Return-Path: Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: (qmail 11194 invoked from network); 6 Jan 2011 20:09:09 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 6 Jan 2011 20:09:09 -0000 Received: (qmail 71132 invoked by uid 500); 6 Jan 2011 20:09:09 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 71117 invoked by uid 500); 6 Jan 2011 20:09:09 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 71109 invoked by uid 99); 6 Jan 2011 20:09:09 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Jan 2011 20:09:09 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Jan 2011 20:09:07 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id p06K8kSM027907 for ; Thu, 6 Jan 2011 20:08:46 GMT Message-ID: <12963721.196491294344526119.JavaMail.jira@thor> Date: Thu, 6 Jan 2011 15:08:46 -0500 (EST) From: "Gary Dusbabek (JIRA)" To: commits@cassandra.apache.org Subject: [jira] Commented: (CASSANDRA-1923) unit tests that validate that message serialization isn't broken in the current version. In-Reply-To: <16405081.74081293740145643.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/CASSANDRA-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12978487#action_12978487 ] Gary Dusbabek commented on CASSANDRA-1923: ------------------------------------------ the txt patches are against trunk, the 0.7 patches are labeled as such. serializations can be generated with `ant msg-ser-gen-test`. serialization tests can be run (after generating serializations) with `ant msg-ser-test`. 1923-0.7-binary.zip contains the serialized messages for 0.7. unzip them into test/data. It looks like we already have to wire incompatibilities to deal with. :) > unit tests that validate that message serialization isn't broken in the current version. > ---------------------------------------------------------------------------------------- > > Key: CASSANDRA-1923 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1923 > Project: Cassandra > Issue Type: Sub-task > Components: Core > Reporter: Gary Dusbabek > Assignee: Gary Dusbabek > Priority: Minor > Fix For: 0.7.1 > > Attachments: 1923-0.7-binary.zip, 1923-0.7-code.diff, v1-0001-ICompactSerializer-assumptions-test.txt, v1-0002-Serialization-tests.txt, v1-0003-build-changes-to-run-test.txt, v1-0004-notes.txt > > > There are two components to this. First, code that will generate the serialized messages. Second, code that will attempt to read the serialized messages. > My plan is to commit this to 0.7.1 with generated serialized messages. Then I will merge that into trunk sans the generation code. A similar process will need to take place when we branch trunk to create 0.8, etc. On second thought, maybe it makes sense to keep the generation code and let it morph as the message formats change. > If the tests ever break in the 0.7 branch, that means we've created a message incompatibility regression that needs to be fixed. If the tests ever break in trunk (post CASSANDRA-1015), it means that something in trunk has changed message serialization compatibility that will need to be restored (via whatever process is used for 1015). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.