cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <>
Subject [jira] Commented: (CASSANDRA-1998) Make offsets in ByteBufferUtil.* methods relatif to the ByteBuffer position()
Date Mon, 17 Jan 2011 20:25:44 GMT


Jonathan Ellis commented on CASSANDRA-1998:

I don't like trying to impose a convention where it feels like we are actively fighting the
API as designed; it's the very definition of a leaky abstraction and I think it will be more
work to try to keep everyone using the abstraction (especially as new people join the project)
than it is worth.  So I am -0 on that but I'm interested to see what others think.

Committed the EMPTY_BB move.

> Make offsets in ByteBufferUtil.* methods relatif to the ByteBuffer position()
> -----------------------------------------------------------------------------
>                 Key: CASSANDRA-1998
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.8
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>            Priority: Minor
>             Fix For: 0.8
>         Attachments: 0001-0.7-Make-BB-offset-relative-to-position.patch, 0001-Make-BB-offset-relative-to-position.patch,
0002-0.7-Move-EMPTY_BYTE_BUFFER-to-ByteBufferUtil.patch, 0002-Move-EMPTY_BYTE_BUFFER-to-ByteBufferUtil.patch
>   Original Estimate: 2h
>  Remaining Estimate: 2h
> A few methods in ByteBufferUtil take as parameter an offset inside a
> ByteBuffer. When we use them, we always want this offset to be relative to
> ByteBuffer.position(), but it is not, it is relative to the ByteBuffer 0
> position. I argue this is not inline with the way we use ByteBuffers and as a
> consequence, is ugly and error-prone.
> This ticket proposes to make the offset of the ByteBufferUtil.* methods
> relatif to the ByteBuffer position.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message