cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kelvin Kakugawa (JIRA)" <>
Subject [jira] Updated: (CASSANDRA-1937) Keep partitioned counters ("contexts") sorted
Date Tue, 11 Jan 2011 01:48:45 GMT


Kelvin Kakugawa updated CASSANDRA-1937:

    Attachment: CASSANDRA-1937-ALT-0001.patch

The logic refactor looks good.

Fixed an edge case in the attached patch.  In merge(), we don't check whether the right offset
exceeds the right length.

> Keep partitioned counters ("contexts") sorted
> ---------------------------------------------
>                 Key: CASSANDRA-1937
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>             Fix For: 0.8
>         Attachments: 0001-Keep-counter-partitioned-context-sorted.patch, CASSANDRA-1937-ALT-0001.patch
>   Original Estimate: 4h
>          Time Spent: 4h
>  Remaining Estimate: 0h
> In the value of CounterColumns, the code keep the subpart unsorted, but sort
> them 'on the fly' when needed (in diff() and merge()). It will be more
> efficient to keep the parts always sorted (it will also be easier in that it
> will remove the need of the ad-hoc in-place quicksort in CounterContext).
> NOTE: this breaks the on-disk file format (for counters)

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message