cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <>
Subject [jira] Updated: (CASSANDRA-2039) LazilyCompactedRow doesn't add CFInfo to digest
Date Tue, 25 Jan 2011 20:05:47 GMT


Jonathan Ellis updated CASSANDRA-2039:

         Reviewer: jbellis
    Fix Version/s: 0.7.2

this looks okay eyeballing it, but can you add a check to LazilyCompactedRowTest similar to
assertBytes to make sure this stays fixed?

> LazilyCompactedRow doesn't add CFInfo to digest
> -----------------------------------------------
>                 Key: CASSANDRA-2039
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7.0
>            Reporter: Richard Low
>            Priority: Minor
>             Fix For: 0.7.2
>         Attachments: trunk-2038.txt
> LazilyCompactedRow.update doesn't add the CFInfo or columnCount to the digest, so the
hash value in the Merkle tree does not include this data.  However, PrecompactedRow does include
this.  Two consequences of this are:
> * Row-level tombstones are not compared when using LazilyCompactedRow so could remain
> * LazilyCompactedRow and PrecompactedRow produce different hashes of the same row, so
if two nodes have differing in_memory_compaction_limit_in_mb values, rows of size in between
the two limits will have different hashes so will always be repaired even when they are the

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message