cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kelvin Kakugawa (JIRA)" <>
Subject [jira] Commented: (CASSANDRA-1936) Fit partitioned counter directly into CounterColumn.value
Date Wed, 26 Jan 2011 22:42:45 GMT


Kelvin Kakugawa commented on CASSANDRA-1936:

I looked through the code, it looks good.

I'm glad you removed that updateCommutativeTypes method and the, now irrelevant, update method.

> Fit partitioned counter directly into CounterColumn.value 
> ----------------------------------------------------------
>                 Key: CASSANDRA-1936
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>             Fix For: 0.8
>         Attachments: 0001-Put-partitioned-counter-directly-in-column-value.patch, 1936-ALT-0001-lazily-materialize-value.patch
>   Original Estimate: 8h
>  Remaining Estimate: 8h
> The current implementation of CounterColumn keeps both the partitioned
> counter and the total value of the counter (that is, the sum of the parts of
> the partitioned counter).
> This waste space and this requires the code to keep both representation in
> sync. This ticket propose to remove the total value from the representation
> and to only calculate it when returning the value to the client.
> NOTE: this breaks the on-disk file format (for counters)

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message