Return-Path: Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: (qmail 75289 invoked from network); 11 Dec 2010 07:37:36 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 11 Dec 2010 07:37:36 -0000 Received: (qmail 11640 invoked by uid 500); 11 Dec 2010 07:37:36 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 11625 invoked by uid 500); 11 Dec 2010 07:37:36 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 11617 invoked by uid 99); 11 Dec 2010 07:37:36 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Dec 2010 07:37:36 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Dec 2010 07:37:34 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id oBB7bCoB022859 for ; Sat, 11 Dec 2010 07:37:12 GMT Message-ID: <31034810.70581292053032814.JavaMail.jira@thor> Date: Sat, 11 Dec 2010 02:37:12 -0500 (EST) From: "Hudson (JIRA)" To: commits@cassandra.apache.org Subject: [jira] Commented: (CASSANDRA-1778) Change classloader strategy to load version from non system classloader In-Reply-To: <32711805.305631290676815389.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/CASSANDRA-1778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970404#action_12970404 ] Hudson commented on CASSANDRA-1778: ----------------------------------- Integrated in Cassandra-0.7 #70 (See [https://hudson.apache.org/hudson/job/Cassandra-0.7/70/]) > Change classloader strategy to load version from non system classloader > ----------------------------------------------------------------------- > > Key: CASSANDRA-1778 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1778 > Project: Cassandra > Issue Type: Improvement > Components: Core > Affects Versions: 0.7 beta 3 > Reporter: Bram de Kruijff > Assignee: Bram de Kruijff > > At present when initializing the StorageService, FBUtilities.getReleaseVersionString() tries to load the version.info resource from the ClassLoader.getSystemClassLoader(). This typically fails in an embedded scenario (such as an OSGi container) resulting in a dummy version at INFO and a stacktrace at WARN > logger_.warn("Unable to load version.properties", e); > return "debug version"; > My guess is that changing the implementation to using the FBUtilities.class.getClassLoader() for loading resources would solve it and will work in almost any case I can think off. However, as discussed on the Apache Felix mailing list, the only "right"way to do it is to allow an optional ClassLoader to be specified (@see http://www.mail-archive.com/users@felix.apache.org/msg09060.html). > This issue was initially reported at the Amdatu jira: > http://jira.amdatu.org/jira/browse/AMDATU-127 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.