Return-Path: Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: (qmail 67386 invoked from network); 14 Dec 2010 13:35:28 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 14 Dec 2010 13:35:28 -0000 Received: (qmail 40342 invoked by uid 500); 14 Dec 2010 13:35:28 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 40189 invoked by uid 500); 14 Dec 2010 13:35:25 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 40177 invoked by uid 99); 14 Dec 2010 13:35:25 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Dec 2010 13:35:25 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Dec 2010 13:35:24 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id oBEDZ4ml018882 for ; Tue, 14 Dec 2010 13:35:04 GMT Message-ID: <26919992.113441292333704336.JavaMail.jira@thor> Date: Tue, 14 Dec 2010 08:35:04 -0500 (EST) From: "Jonathan Ellis (JIRA)" To: commits@cassandra.apache.org Subject: [jira] Resolved: (CASSANDRA-1856) nodetool "snapshot" improvements In-Reply-To: <5317747.104111292286483294.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Ellis resolved CASSANDRA-1856. --------------------------------------- Resolution: Duplicate Assignee: (was: Jon Hermes) > nodetool "snapshot" improvements > -------------------------------- > > Key: CASSANDRA-1856 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1856 > Project: Cassandra > Issue Type: Improvement > Components: Tools > Reporter: Robert Coli > Priority: Trivial > > Summary : "nodetool snapshot" is actually hooked up to the MBean endpoint takeAllSnapshot. takeAllSnapshot snapshots all CFs in all Keyspaces. > It would be good if "nodetool snapshot" took a mandatory Keyspace argument and an optional (list of?) CF name(s?), perhaps mapped to "takeSnapshot" instead of "takeAllSnapshot". > =Rob > PS - > As a side note, I have never been too pleased with the behavior of "nodetool snapshot" as regards snapshot naming. Most of the time, when someone names something something specific, it ends up actually named that something, but.. > "nodetool snapshot foobarbaz" > ... does not result in a snapshot at "/path/to/datadir/Keyspace/snapshots/foobarbaz", the snapshot ends up at "/p/t/dd/Keyspace/snapshots/-foobarbaz". > When I asked jbellis about this, he basically said it was to avoid having to deal with the possibility that the directory might already exist. If you are mucking about in the snapshot code, you might (or might not!) want to "fix" this behavior. :D -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.