Return-Path: 
 <commits-return-23305-apmail-cassandra-commits-archive=cassandra.apache.org@cassandra.apache.org>
Delivered-To: apmail-cassandra-commits-archive@www.apache.org
Received: (qmail 85955 invoked from network); 17 Dec 2010 03:05:24 -0000
Received: from unknown (HELO mail.apache.org) (140.211.11.3)
  by 140.211.11.9 with SMTP; 17 Dec 2010 03:05:24 -0000
Received: (qmail 39760 invoked by uid 500); 17 Dec 2010 03:05:24 -0000
Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org
Received: (qmail 39716 invoked by uid 500); 17 Dec 2010 03:05:23 -0000
Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@cassandra.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@cassandra.apache.org>
List-Post: <mailto:commits@cassandra.apache.org>
List-Id: <commits.cassandra.apache.org>
Reply-To: dev@cassandra.apache.org
Delivered-To: mailing list commits@cassandra.apache.org
Received: (qmail 39708 invoked by uid 99); 17 Dec 2010 03:05:23 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Dec 2010 03:05:23 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=10.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Dec 2010 03:05:22 +0000
Received: from thor (localhost [127.0.0.1])
	by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id oBH352BG019352
	for <commits@cassandra.apache.org>; Fri, 17 Dec 2010 03:05:02 GMT
Message-ID: <23607667.171091292555102570.JavaMail.jira@thor>
Date: Thu, 16 Dec 2010 22:05:02 -0500 (EST)
From: "Jonathan Ellis (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Subject: [jira] Updated: (CASSANDRA-1265) make getBuckets deterministic
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


     [ https://issues.apache.org/jira/browse/CASSANDRA-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-1265:
--------------------------------------

    Affects Version/s:     (was: 0.6.3)
                       0.6
        Fix Version/s:     (was: 0.6.4)
                       0.7 beta 1
                       0.6.9

actually committed to 0.6 finally. updated fix-for version.

> make getBuckets deterministic
> -----------------------------
>
>                 Key: CASSANDRA-1265
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1265
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Jonathan Ellis
>            Assignee: Tyler Hobbs
>            Priority: Minor
>             Fix For: 0.6.9, 0.7 beta 1
>
>         Attachments: cassandra-0.6-1265.txt, cassandra-0.6-1265.txt
>
>
> CompactionManager.getBuckets is nondeterministic as explained in the parent issue.
> This can be fixed either by sorting in getBuckets, or requiring that the iterable passed be sorted already.  Either is fine.
> We also need to add some unit tests to CompactionManagerTest for getBuckets.  We need to decouple getBuckets a little to do this sanely; rather than examining sstable length directly or introducing some extra interface, let's declare getBuckets as
>     static Set<List<T>> getBuckets(Iterable<Pair<T, Integer>> files, long min)
> where the integer in the pair is the file size.  Then you can write tests against Strings instead of SSTableReaders.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.