Return-Path: Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: (qmail 95501 invoked from network); 27 Dec 2010 17:51:57 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 27 Dec 2010 17:51:57 -0000 Received: (qmail 23896 invoked by uid 500); 27 Dec 2010 17:51:56 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 23880 invoked by uid 500); 27 Dec 2010 17:51:56 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 23872 invoked by uid 99); 27 Dec 2010 17:51:56 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Dec 2010 17:51:56 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Dec 2010 17:51:54 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 7E9DD238897A; Mon, 27 Dec 2010 17:51:33 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1053117 - /cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/utils/FBUtilities.java Date: Mon, 27 Dec 2010 17:51:33 -0000 To: commits@cassandra.apache.org From: jbellis@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20101227175133.7E9DD238897A@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: jbellis Date: Mon Dec 27 17:51:33 2010 New Revision: 1053117 URL: http://svn.apache.org/viewvc?rev=1053117&view=rev Log: clean up FBUtilities patch by Jon Hermes and jbellis Modified: cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/utils/FBUtilities.java Modified: cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/utils/FBUtilities.java URL: http://svn.apache.org/viewvc/cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/utils/FBUtilities.java?rev=1053117&r1=1053116&r2=1053117&view=diff ============================================================================== --- cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/utils/FBUtilities.java (original) +++ cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/utils/FBUtilities.java Mon Dec 27 17:51:33 2010 @@ -19,7 +19,6 @@ package org.apache.cassandra.utils; import java.io.*; -import java.lang.reflect.Constructor; import java.lang.reflect.Field; import java.lang.reflect.InvocationTargetException; import java.math.BigInteger; @@ -147,7 +146,7 @@ public class FBUtilities remainder = distance.testBit(0); midpoint = distance.shiftRight(1).add(left).mod(max); } - return new Pair(midpoint, remainder); + return new Pair(midpoint, remainder); } public static ByteBuffer toByteBuffer(int i) @@ -489,9 +488,7 @@ public class FBUtilities public static String decodeToUTF8(ByteBuffer bytes) throws CharacterCodingException { - bytes = bytes.duplicate(); - String decoded = Charsets.UTF_8.newDecoder().decode(bytes).toString(); - return decoded; + return Charsets.UTF_8.newDecoder().decode(bytes.duplicate()).toString(); } public static ByteBuffer toByteBuffer(long n) @@ -558,7 +555,7 @@ public class FBUtilities { if (!partitionerClassName.contains(".")) partitionerClassName = "org.apache.cassandra.dht." + partitionerClassName; - return FBUtilities.construct(partitionerClassName, "partitioner"); + return FBUtilities.construct(partitionerClassName, "partitioner"); } public static AbstractType getComparator(String compareWith) throws ConfigurationException @@ -611,11 +608,10 @@ public class FBUtilities */ public static T construct(String classname, String readable) throws ConfigurationException { - Class cls = FBUtilities.classForName(classname, readable); + Class cls = FBUtilities.classForName(classname, readable); try { - Constructor ctor = cls.getConstructor(); - return (T)ctor.newInstance(); + return cls.getConstructor().newInstance(); } catch (NoSuchMethodException e) { @@ -648,12 +644,6 @@ public class FBUtilities return joiner.join(map); } - /** slow! */ - private static Object toString(Object o) - { - return o.getClass().isArray() ? Arrays.toString((Object[]) o) : o.toString(); - } - /** * Used to get access to protected/private field of the specified class * @param klass - name of the class