Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Message-ID: <13590402.29601291143855027.JavaMail.jira@thor>
Date: Tue, 30 Nov 2010 14:04:15 -0500 (EST)
From: "Jonathan Ellis (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Subject: [jira] Commented: (CASSANDRA-1792) Reduce byte array copies when
 using serialization/deserialization helper methods
In-Reply-To: <18822233.29211291142891713.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12965345#action_12965345 ] 

Jonathan Ellis commented on CASSANDRA-1792:
-------------------------------------------

i don't know enough about thrift internals to tell if there is potential for unflushed data to be in the TProtocol/TIOStreamTransport pipeline this way.  if we can rule that out then it looks good to me.

> Reduce byte array copies when using serialization/deserialization helper methods 
> ---------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1792
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1792
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: T Jake Luciani
>            Priority: Minor
>         Attachments: 1792_v1.txt
>
>
> From looking at CASSANDRA-1765 it seems FBUtilities serialize and deserialize methods unnecessarily make byte[] copies due to the way TSerializer is being used.  
> This can be changed to avoid making any copies. 
> These methods are only used in a couple serializers so not a big issue at this point. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.