cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stu Hood (JIRA)" <j...@apache.org>
Subject [jira] Updated: (CASSANDRA-1729) Fix misuse of DataOutputBuffer.getData in AntiEntropyService
Date Thu, 11 Nov 2010 17:39:14 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Stu Hood updated CASSANDRA-1729:
--------------------------------

    Description: 
As reported by Schubert Zhang, AntiEntropyService is ignoring the length of the input buffer.
{code:java}
byte[] rowhash = FBUtilities.hash("SHA-256", row.key.key.getBytes(), row.buffer.getData());
{code}

While this isn't affecting our accuracy, it would break validation if we started reusing buffers
in CompactedRow. This issue has already been fixed in 0.7.

  was:
As reported by Schubert Zhang, AntiEntropyService is ignoring the length of the input buffer.
{code:java}
byte[] rowhash = FBUtilities.hash("SHA-256", row.key.key.getBytes(), row.buffer.getData());
{code}

While this isn't effecting our accuracy, it would break validation if we started reusing buffers
in CompactedRow. This issue has already been fixed in 0.7.


> Fix misuse of DataOutputBuffer.getData in AntiEntropyService
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-1729
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1729
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Stu Hood
>            Assignee: Stu Hood
>            Priority: Minor
>             Fix For: 0.6.8
>
>         Attachments: 0001-Remove-varargs-from-FBUtilities.hash-and-correctly-use.txt
>
>
> As reported by Schubert Zhang, AntiEntropyService is ignoring the length of the input
buffer.
> {code:java}
> byte[] rowhash = FBUtilities.hash("SHA-256", row.key.key.getBytes(), row.buffer.getData());
> {code}
> While this isn't affecting our accuracy, it would break validation if we started reusing
buffers in CompactedRow. This issue has already been fixed in 0.7.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message