cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Tower (JIRA)" <j...@apache.org>
Subject [jira] Updated: (CASSANDRA-1753) SSTableImport adds columns marked for delete incorrectly in methods addToStandardCF & addToSuperCF
Date Wed, 17 Nov 2010 22:27:20 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Bryan Tower updated CASSANDRA-1753:
-----------------------------------

    Attachment: cassandra-0.7-1753.txt

This patch adds a check to the SSTableImportTest to make sure that the retrieved Column is
not deleted and fixes the bug in the SSTableImport.java by switching the logic on the isDeletedCheck.


> SSTableImport adds columns marked for delete incorrectly in methods addToStandardCF &
addToSuperCF
> --------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1753
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1753
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 0.7 beta 2
>            Reporter: Pushpinder Heer
>            Priority: Minor
>         Attachments: cassandra-0.7-1753.txt
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The logic for adding column families in the methods addToStandardCF & addToSuperCF
appears to be backwards
>             if (col.isDeleted) {
>                 cfamily.addColumn(path, hexToBytes(col.value), new TimestampClock(col.timestamp));
>             } else {
>                 cfamily.addTombstone(path, hexToBytes(col.value), new TimestampClock(col.timestamp));
>             }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message