Return-Path: Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: (qmail 6057 invoked from network); 28 Oct 2010 18:30:46 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 28 Oct 2010 18:30:46 -0000 Received: (qmail 45281 invoked by uid 500); 28 Oct 2010 18:30:46 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 45254 invoked by uid 500); 28 Oct 2010 18:30:46 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 45246 invoked by uid 99); 28 Oct 2010 18:30:46 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Oct 2010 18:30:46 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Oct 2010 18:30:43 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o9SIULps011959 for ; Thu, 28 Oct 2010 18:30:22 GMT Message-ID: <8699857.125381288290621732.JavaMail.jira@thor> Date: Thu, 28 Oct 2010 14:30:21 -0400 (EDT) From: "Jonathan Ellis (JIRA)" To: commits@cassandra.apache.org Subject: [jira] Assigned: (CASSANDRA-1678) describe_schema_versions does not list downed hosts In-Reply-To: <24286695.125131288289781373.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/CASSANDRA-1678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Ellis reassigned CASSANDRA-1678: ----------------------------------------- Assignee: Gary Dusbabek Odd, I see the code trying to add the missing hosts in describeSchemaVersions: {code} results.put(DatabaseDescriptor.INITIAL_VERSION.toString(), missingHostNames); {code} But IMO the right fix is to avoid that entirely and do the simple thing instead: {code} /** * for each schema version present in the cluster, returns a list of nodes at that version. * hosts that do not respond will not be included. * the cluster is all on the same version if the size of the map is 1 and the * length of the list in that map value is the number of nodes in the cluster. */ {code} > describe_schema_versions does not list downed hosts > --------------------------------------------------- > > Key: CASSANDRA-1678 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1678 > Project: Cassandra > Issue Type: Bug > Components: API > Affects Versions: 0.7 beta 2 > Reporter: Edward Capriolo > Assignee: Gary Dusbabek > Priority: Minor > > According to the description unreachable hosts should be listed. It does not seem like they are. > {noformat} > map> describe_schema_versions() > [java] key:c3f38ebc-e1c5-11df-95a0-e700f669bcfc > [java] 127.0.0.2 > [java] 127.0.0.3 > [java] 127.0.0.4 > [java] 127.0.0.1 > Address Status State Load Token > 105444142448428656124184491892431731479 > 127.0.0.3 Up Normal 56.53 KB 43021486531749787992103274496183765897 > 127.0.0.1 Up Normal 56.24 KB 49910048177093876350019363877113991186 > 127.0.0.5 Down Normal 52.49 KB 64377498999076014343862177049497951437 > 127.0.0.2 Up Normal 65.27 KB 84713069031498515281943177906254878023 > 127.0.0.4 Up Normal 55.95 KB 105444142448428656124184491892431731479 > {noformat} > The code looks like this: > {noformat} > Cassandra.Client client = fcw.getClient(); > Map> sv =client.describe_schema_versions(); > for (Map.Entry> mapEntry: sv.entrySet()){ > System.out.println("key:"+mapEntry.getKey()); > for (String listForKey : mapEntry.getValue()){ > System.out.println("\t"+listForKey); > } > } > {noformat} -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.