Return-Path: Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: (qmail 14181 invoked from network); 21 Oct 2010 21:34:38 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 21 Oct 2010 21:34:38 -0000 Received: (qmail 269 invoked by uid 500); 21 Oct 2010 21:34:38 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 245 invoked by uid 500); 21 Oct 2010 21:34:38 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 237 invoked by uid 99); 21 Oct 2010 21:34:38 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Oct 2010 21:34:38 +0000 X-ASF-Spam-Status: No, hits=-1996.4 required=10.0 tests=ALL_TRUSTED,FS_REPLICA X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Oct 2010 21:34:37 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o9LLYG5P023631 for ; Thu, 21 Oct 2010 21:34:17 GMT Message-ID: <8035681.17261287696856906.JavaMail.jira@thor> Date: Thu, 21 Oct 2010 17:34:16 -0400 (EDT) From: "Jon Hermes (JIRA)" To: commits@cassandra.apache.org Subject: [jira] Updated: (CASSANDRA-1263) Push replication factor down to the replication strategy In-Reply-To: <16309702.286341278695090053.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-1263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Hermes updated CASSANDRA-1263: ---------------------------------- Attachment: 1263-incomplete.txt Rep_factor has been wiped off the face of the earth, and the engine for its usage was nicely wrapped up in DD.getReplicationFactor(), so now that just gets the strat for the keyspace and calls strat.getRF(). Converter does the right thing, and the CLI still does the right thing. ConfigurationException throwing/handling still needs to be glued onto strategies (most likely in ARS). The problem right now is that YAML is being finicky, and is either trying to load a map as a non-collection, or it tries to expand the map in place and check for a property on RawKeyspace for every arbitrary strat_opt. In any event, I'm attaching the partial patch now to make sure it doesn't get lost in the revision-shuffle (and because it's more code than I thought it would be). The best time to finish this may be in a larger YAML/config fix. > Push replication factor down to the replication strategy > -------------------------------------------------------- > > Key: CASSANDRA-1263 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1263 > Project: Cassandra > Issue Type: Task > Components: Core > Reporter: Jeremy Hanna > Assignee: Jon Hermes > Priority: Minor > Fix For: 0.7.0 > > Attachments: 1263-incomplete.txt > > > Currently the replication factor is in the keyspace metadata. As we've added the datacenter shard strategy, the replication factor becomes more computed by the replication strategy. It seems reasonable to therefore push the replication factor for the keyspace down to the replication strategy so that it can be handled in one place. > This adds on the work being done in CASSANDRA-1066 since that ticket will make the replication strategy a member variable of keyspace metadata instead of just a quasi singleton giving the replication strategy state for each keyspace. That makes it able to have the replication factor. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.