cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-1570) sort is not necessary for getMaxEndpointStateVersion() in Gossiper
Date Tue, 05 Oct 2010 13:25:37 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917972#action_12917972
] 

Hudson commented on CASSANDRA-1570:
-----------------------------------

Integrated in Cassandra #556 (See [https://hudson.apache.org/hudson/job/Cassandra/556/])
    r/m unnecessary sort from Gossiper.getMaxEndpointStateVersion.  patch by iryoung jeong;
reviewed by jbellis for CASSANDRA-1570


> sort is not necessary for getMaxEndpointStateVersion() in Gossiper
> ------------------------------------------------------------------
>
>                 Key: CASSANDRA-1570
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1570
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: iryoung jeong
>            Assignee: iryoung jeong
>            Priority: Minor
>             Fix For: 0.7.0
>
>         Attachments: trunk-1570-1.txt, trunk-1570-2.txt
>
>
> hello, 
> while I reviewing the cassandra source code, I think, there's redundant sort in getMaxEndpointStateVersion()
in Gossiper.
> To get a max value, sorting is not necessary.. isn't it?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message