Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Message-ID: <22969879.159441284405514339.JavaMail.jira@thor>
Date: Mon, 13 Sep 2010 15:18:34 -0400 (EDT)
From: "Jon Hermes (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Subject: [jira] Commented: (CASSANDRA-1468) allow setting
 CompactionManager.min|max compactionThreshold in configuration file
In-Reply-To: <10993558.26461283573073375.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908945#action_12908945 ] 

Jon Hermes commented on CASSANDRA-1468:
---------------------------------------

I can't decide on 1) what to do with the get/set min/maxCompactionThreshold methods, and 2) where to do the null->default checking from the config (we do this in multiple ways per property, so no hard and fast rule to follow).

For 1), Since these thresholds apply per CF, I have to take in the name for any getter or setter. Should disabling auto-compaction affect all CFs or a given CF? Should the nodetool function for getting the thresholds just return a list of the thresholds per-CF?

For 2), I have maps for cfname-to-min/maxthreshold in the CompactionManager, and lazily defaults to a DEFAULT_BLAH in CompactionManager. (I have to append keyspace or make that an outer mapping, otherwise there's a conflict if two CFs in different keyspaces have the same name and different thresholds.) Should I move this over to CFMetaData and default it as it comes in instead?

> allow setting CompactionManager.min|max compactionThreshold in configuration file
> ---------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1468
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1468
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.7.0
>            Reporter: Jonathan Ellis
>            Assignee: Jon Hermes
>             Fix For: 0.7.0
>
>
> currently we can set these via JMX but there is no way to set them persistently.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.