cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jon Hermes (JIRA)" <>
Subject [jira] Commented: (CASSANDRA-1468) allow setting CompactionManager.min|max compactionThreshold in configuration file
Date Mon, 13 Sep 2010 19:18:34 GMT


Jon Hermes commented on CASSANDRA-1468:

I can't decide on 1) what to do with the get/set min/maxCompactionThreshold methods, and 2)
where to do the null->default checking from the config (we do this in multiple ways per
property, so no hard and fast rule to follow).

For 1), Since these thresholds apply per CF, I have to take in the name for any getter or
setter. Should disabling auto-compaction affect all CFs or a given CF? Should the nodetool
function for getting the thresholds just return a list of the thresholds per-CF?

For 2), I have maps for cfname-to-min/maxthreshold in the CompactionManager, and lazily defaults
to a DEFAULT_BLAH in CompactionManager. (I have to append keyspace or make that an outer mapping,
otherwise there's a conflict if two CFs in different keyspaces have the same name and different
thresholds.) Should I move this over to CFMetaData and default it as it comes in instead?

> allow setting CompactionManager.min|max compactionThreshold in configuration file
> ---------------------------------------------------------------------------------
>                 Key: CASSANDRA-1468
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.7.0
>            Reporter: Jonathan Ellis
>            Assignee: Jon Hermes
>             Fix For: 0.7.0
> currently we can set these via JMX but there is no way to set them persistently.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message