cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Goffinet (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (CASSANDRA-1424) Allow fine-tuning of Thrift TCP behavior for Thrift-managed sockets
Date Fri, 10 Sep 2010 04:53:34 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907881#action_12907881
] 

Chris Goffinet edited comment on CASSANDRA-1424 at 9/10/10 12:53 AM:
---------------------------------------------------------------------

I support this as well, we are doing similar things at Digg. I like the keepAlive support.
I think we should also support letting our users pick which ThriftServer. There are pro's
and con's to all of this and forcing Thread per connection IMHO is not the right way to go.


      was (Author: lenn0x):
    I support this as well, we are doing similar things at Digg. I'll try to see if I can
work up a patch if folks feel its useful as well? I like the keepAlive support. I think we
should also support letting our users pick which ThriftServer. There are pro's and con's to
all of this and forcing Thread per connection IMHO is not the right way to go.

  
> Allow fine-tuning of Thrift TCP behavior for Thrift-managed sockets
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-1424
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1424
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.7 beta 1, 0.7 beta 2, 0.7.0
>            Reporter: Erik Onnen
>            Priority: Minor
>             Fix For: 0.7.0
>
>         Attachments: CAS-1424.patch
>
>
> Would be nice to be able to control low-level TCP socket behaviors for the Thrift-managed
sockets used by o.a.c.thrift.CassandraDaemon.
> Blatantly stole the idea from here: http://mail-archives.apache.org/mod_mbox/hadoop-hive-commits/201006.mbox/%3C20100616044535.E781723889CB@eris.apache.org%3E
> Patch attached, implemented to retain default behavior with current system but allows
definition of the following in cassandra.yaml:
> * rpc_keepalive (default:false)
> * rpc_reuse_addrs (default:false)
> * rpc_send_buff_size_in_bytes (default:undefined)
> * rpc_recv_buff_size_in_bytes (default:undefined)
> Wasn't sure how/if to write a unit test so could use some advice there.
> Verified that configs are picked up correctly and the socket accepts them on Linux 2.6
kernel.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message