Return-Path: Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: (qmail 90860 invoked from network); 4 Aug 2010 00:32:41 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 4 Aug 2010 00:32:41 -0000 Received: (qmail 429 invoked by uid 500); 4 Aug 2010 00:32:41 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 411 invoked by uid 500); 4 Aug 2010 00:32:41 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 403 invoked by uid 99); 4 Aug 2010 00:32:41 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Aug 2010 00:32:41 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Aug 2010 00:32:40 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o740WKGC021670 for ; Wed, 4 Aug 2010 00:32:20 GMT Message-ID: <32782355.149381280881940225.JavaMail.jira@thor> Date: Tue, 3 Aug 2010 20:32:20 -0400 (EDT) From: "Jonathan Ellis (JIRA)" To: commits@cassandra.apache.org Subject: [jira] Commented: (CASSANDRA-1269) improve test coverage of BufferedRandomAccessFile In-Reply-To: <25485504.317951278889491386.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895105#action_12895105 ] Jonathan Ellis commented on CASSANDRA-1269: ------------------------------------------- Can you clarify what you mean by that last? Personally, I want to be confident that errors at the storage layer are from regressions in our sstable logic, rather than BRAF (which I made some pretty large change to during 0.7). So, we're trying to test "everything." 100% line coverage is a reasonable approximation to that. > improve test coverage of BufferedRandomAccessFile > ------------------------------------------------- > > Key: CASSANDRA-1269 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1269 > Project: Cassandra > Issue Type: Task > Components: Core > Reporter: Jonathan Ellis > Assignee: Jon Hermes > Priority: Minor > Fix For: 0.7.0 > > Attachments: 1269.txt > > > We have a BRAFTest but it doesn't do a whole lot. Seems like we ought to be able to get to 100% line-based coverage w/ white-box testing. http://wiki.apache.org/cassandra/HowToContribute has instructions for setting up code coverage. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.