Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Message-ID: <2193830.85761283223534644.JavaMail.jira@thor>
Date: Mon, 30 Aug 2010 22:58:54 -0400 (EDT)
From: "Eric Evans (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Subject: [jira] Commented: (CASSANDRA-1446) cassandra-cli still relies on
 cassandra.in.sh instead of cassandra-env.sh
In-Reply-To: <5446175.79361283208475844.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-1446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904504#action_12904504 ] 

Eric Evans commented on CASSANDRA-1446:
---------------------------------------

{quote}
The specific problem I'm seeing here is that the user can launch cassandra itself, but doesn't have enough memory to launch cassandra-cli afterwards, and there isn't an intuitive way to change cassandra-cli's heap.
{quote}

Interesting.  I would have thought the default max heap size would be something... reasonable, but on my machine it seems to be 987MB (the hell?!).

Anyway, I just checked in a change that sets this to 256MB.  I don't know if that's the optimal value but it's considerably less than the almost-a-gig default.  The only reason it would ever need to be bigger than say 16MB is to buffer larger responses, and 256MB seems like a gracious plenty for any practical use of our CLI.

{quote}
I see cassandra-cli's script specifically trying to include cassandra.in.sh, though, on second look, it does not appear to be doing anything with it. Maybe we should just remove the cassandra.in.sh cruft.
{quote}

It is using it though, it's using it to setup the classpath; cassandra.in.sh is basically the common code for setting the classpath in all of those scripts.

> cassandra-cli still relies on cassandra.in.sh instead of cassandra-env.sh
> -------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1446
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1446
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.7 beta 1
>            Reporter: Brandon Williams
>            Assignee: Eric Evans
>            Priority: Trivial
>             Fix For: 0.7 beta 2
>
>
> When we switched to cassandra-env.sh, we neglected to change the cli as well.  This leads to people unable to launch to the client due to heap size, and not having any idea how to change the heap for the cli itself.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.