cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Bailey (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-1216) removetoken drops node from ring before re-replicating its data is finished
Date Mon, 23 Aug 2010 21:13:17 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901589#action_12901589
] 

Nick Bailey commented on CASSANDRA-1216:
----------------------------------------

bq. (minor nit) I wish there were a way to assert that tmd.getLeavingNodes() actually has
nodes in it.

This is what tmd.isLeaving() does

bq. testStartRemoving should assert preconditions before calling ss.onChange (it also makes
the same assertion twice).

I'm not sure what preconditions you mean. I added an assertion to make sure there are no endpoints
already leaving.

bq. SS.removeToken() shouldn't throw a RuntimeException,

Do you think the UnsupportedOperationExceptions should be removed as well? These existed previously.

I modified the callback support for streaming so that the code should wait for all streams
to finish before confirming. I also added a reply to the ReplicationFinishedHandler so the
IAsyncResult will be updated.  

Thoughts?

The timeout values for waiting on the latches still need to be updated.


> removetoken drops node from ring before re-replicating its data is finished
> ---------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1216
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1216
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Nick Bailey
>             Fix For: 0.7 beta 2
>
>         Attachments: 0001-Add-callbacks-to-streaming.patch, 0002-Modify-removeToken-to-be-similar-to-decommission.patch,
0003-Fixes-to-old-tests.patch, 0004-Additional-tests-for-removeToken.patch
>
>
> this means that if something goes wrong during the re-replication (e.g. a source node
is restarted) there is (a) no indication that anything has gone wrong and (b) no way to restart
the process (other than the Big Hammer of running repair)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message