Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Message-ID: <29177457.208911278384651034.JavaMail.jira@thor>
Date: Mon, 5 Jul 2010 22:50:51 -0400 (EDT)
From: "Jonathan Ellis (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Subject: [jira] Resolved: (CASSANDRA-1252) @Override annotation on
 implementing methods
In-Reply-To: <3021410.208161278374570387.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/CASSANDRA-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis resolved CASSANDRA-1252.
---------------------------------------

    Resolution: Not A Problem

Even Josh Bloch agrees that @Override is redundant when implementing abstract or interface methods.

> @Override annotation on implementing methods
> --------------------------------------------
>
>                 Key: CASSANDRA-1252
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1252
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Folke Behrens
>
> The current [CodeStyle|http://wiki.apache.org/cassandra/CodeStyle] states that one should "avoid redundant @Override annotations when implementing abstract or interface methods." A rationale is not given.
> The @Override annotation is not redundant. When putting it on implementing methods it helps detecting abstract methods of super-classes or interfaces that were removed. This is especially important when extending abstract classes or implementing interfaces from external libraries.
> Please tag every overriding method with @Override and make compiler warnings errors.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.