cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tyler L. Hobbs (JIRA)" <>
Subject [jira] Updated: (CASSANDRA-1265) make getBuckets deterministic
Date Sat, 10 Jul 2010 06:53:50 GMT


Tyler L. Hobbs updated CASSANDRA-1265:

    Attachment: cassandra-0.6-1265.txt

> make getBuckets deterministic
> -----------------------------
>                 Key: CASSANDRA-1265
>                 URL:
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.6.4
>         Attachments: cassandra-0.6-1265.txt
> CompactionManager.getBuckets is nondeterministic as explained in the parent issue.
> This can be fixed either by sorting in getBuckets, or requiring that the iterable passed
be sorted already.  Either is fine.
> We also need to add some unit tests to CompactionManagerTest for getBuckets.  We need
to decouple getBuckets a little to do this sanely; rather than examining sstable length directly
or introducing some extra interface, let's declare getBuckets as
>     static Set<List<T>> getBuckets(Iterable<Pair<T, Integer>>
files, long min)
> where the integer in the pair is the file size.  Then you can write tests against Strings
instead of SSTableReaders.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message