cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-1191) Make Strategy classes fail if asked to fulfil an impossible replication request
Date Fri, 30 Jul 2010 22:32:18 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-1191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894180#action_12894180
] 

Jonathan Ellis commented on CASSANDRA-1191:
-------------------------------------------

if you have a nonsensical RF how can you even try to calculate pending ranges?

i think "don't create KS with RF > node count" is a reasonable restriction.  if you plan
to add nodes to make it sane, then do that first instead of the other way around.  (similarly,
"don't create KS when so much of your cluster is down that node count < RF" is also reasonable.)

> Make Strategy classes fail if asked to fulfil an impossible replication request
> -------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1191
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1191
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Matthew F. Dennis
>            Priority: Minor
>             Fix For: 0.7 beta 1
>
>         Attachments: trunk-1191.txt
>
>
> I added to RSECT in CASSANDRA-1147,
>         // TODO DSS is asked to provide a total of 6 replicas, but we never give it 6
endpoints.
>         // thus we are testing undefined behavior, at best.
> This is easiest to cause in DSS but it can afflict other Strategies too.
> Let's update the ARS contract to state that calculateNaturalEndpoints (hence getNaturalEndpoints
too) will throw IllegalStateException if more replicas are requested than the known endpoints
(for DSS, this would apply on a per-DC basis) and amend the Strategy classes to check for
this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message