cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Folke Behrens (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-1252) @Override annotation on implementing methods
Date Tue, 06 Jul 2010 17:23:50 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12885610#action_12885610
] 

Folke Behrens commented on CASSANDRA-1252:
------------------------------------------

Dude, get a copy and read the entire Item 36. Yes, he writes that @Override is unnecessary
for implementing methods because the compiler will warn you if signatures don't match but
he also wrote an entire page about why it is still a good idea to do it anyway.

> @Override annotation on implementing methods
> --------------------------------------------
>
>                 Key: CASSANDRA-1252
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1252
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Folke Behrens
>
> The current [CodeStyle|http://wiki.apache.org/cassandra/CodeStyle] states that one should
"avoid redundant @Override annotations when implementing abstract or interface methods." A
rationale is not given.
> The @Override annotation is not redundant. When putting it on implementing methods it
helps detecting abstract methods of super-classes or interfaces that were removed. This is
especially important when extending abstract classes or implementing interfaces from external
libraries.
> Please tag every overriding method with @Override and make compiler warnings errors.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message