cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-1153) Add index metadata to CFMetadata
Date Sat, 19 Jun 2010 16:09:25 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12880505#action_12880505
] 

Jonathan Ellis commented on CASSANDRA-1153:
-------------------------------------------

let's not use BytesToken for stuff that isn't actually used as a Token.  ByteBuffer would
be reasonable, or using a Map that doesn't rely on hashcode such as TreeMap.

logging an error _and_ re-throwing the same exception is usually more confusing than helpful,
since whoever ends up catching the exception will either handle it (in which case logging
was a mistake) or log it itself (since it shouldn't rely on it also being logged farther up
the call stack).  

validation should only catch MarshalException, not any Throwable

(please leave spaces after keywords such as "if" :)

> Add index metadata to CFMetadata
> --------------------------------
>
>                 Key: CASSANDRA-1153
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1153
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Jonathan Ellis
>            Assignee: Matthew F. Dennis
>             Fix For: 0.7
>
>         Attachments: 1153.txt, trunk-1153-v2.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message