cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Manes (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-975) explore upgrading CLHM
Date Wed, 09 Jun 2010 01:36:13 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12876916#action_12876916
] 

Ben Manes commented on CASSANDRA-975:
-------------------------------------

Jonathan wanted to canary this patch to load test the rewrite. I haven't found / had reported
any race conditions or other problems, but verifying it is always a good idea. Caching has
a noticeable impact on performance and this version is significantly different from the previous
one. It should be better in all respects, but monitoring for any negative changes would be
valuable feedback.

Also note that you don't need to specify the builder#weigher() as it defaults to the singleton
instance. So its a matter of preference if you like being explicit.

> explore upgrading CLHM
> ----------------------
>
>                 Key: CASSANDRA-975
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-975
>             Project: Cassandra
>          Issue Type: Task
>            Reporter: Jonathan Ellis
>            Assignee: Matthew F. Dennis
>            Priority: Minor
>             Fix For: 0.8
>
>         Attachments: 0001-trunk-975.patch
>
>
> The new version should be substantially better "on large caches where many entries were
readon large caches where many entries were read," which is exactly what you see in our row
and key caches.
> http://code.google.com/p/concurrentlinkedhashmap/issues/detail?id=9
> Hopefully we can get Digg to help test, since they could reliably break CLHM when it
was buggy.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message