cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Bailey (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-1232) UTF8Type.compare() is slow and dangerous
Date Wed, 30 Jun 2010 16:49:51 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883978#action_12883978
] 

Nick Bailey commented on CASSANDRA-1232:
----------------------------------------

Hmm I changed the method to explicitly decode as UTF8.  Would we prefer to assume UTF8 at
this point?

> UTF8Type.compare() is slow and dangerous
> ----------------------------------------
>
>                 Key: CASSANDRA-1232
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1232
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Folke Behrens
>            Assignee: Nick Bailey
>             Fix For: 0.6.4
>
>         Attachments: 0001-Fixes-to-UTF8Type-compare-and-getString-methods.patch
>
>
> UTF8Type converts both byte arrays into Strings and then compares them. This is unnecessary
and slow because UTF-8 encoded Strings are already directly comparable. Higher codepoints
yield higher initial and subsequent bytes. One can safely use BytesType.compare() for UTF-8.
Maybe UTF8Type should be a subclass only overriding getString().
> BTW, It's also dangerous to ignore invalid byte sequences. At this point the byte array
should contain valid UTF-8.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message