cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-1105) Create timers to reload cassandra-rack.properties and datacenters.properties
Date Wed, 19 May 2010 21:49:54 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869370#action_12869370
] 

Jonathan Ellis commented on CASSANDRA-1105:
-------------------------------------------

> Would it be better to reload based purely on modified time instead of a minute timer?

No.  We want to avoid doing the reload check during any performance-critical code, and all
the methods here that get called often enough to be useful for a check, are performance-critical.

> Do we need to change the interface or just leave the option to manual-reload? 

Delete PFSMBean and the methods it defines.

> Create timers to reload cassandra-rack.properties and datacenters.properties
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1105
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1105
>             Project: Cassandra
>          Issue Type: Task
>          Components: Core
>            Reporter: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.7
>
>
> PropertyFileSnitch allows reloading changes from its config file manually.  DatacenterShardStrategy
doesn't allow reloading at all [after I ripped out the reload-for-each-getNaturalEndpoints
call code, in CASSANDRA-1103].
> Let's check each of these for changes (modification time on the fs is sufficient) every
minute and reload automatically if changes are seen.  The manual-reload code from PFS can
then be dropped.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message