cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-1070) Update interface to use a wrapper for various clock types
Date Mon, 24 May 2010 23:14:24 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12870902#action_12870902
] 

Jonathan Ellis commented on CASSANDRA-1070:
-------------------------------------------

                    List<IClock> clocks = new LinkedList<IClock>();
                    clocks.add(newClock);
                    newClock = oldClock.getSuperset(clocks);

is better written as

                    newClock = oldClock.getSuperset(Arrays.asList(oldClock));

... but more importantly doesn't 

            IClock oldClock = atomic.getAndSet(newClock);

temporarily set the reference to the new value (even it is smaller than the old), before fixing
it to be the max?  that would be a bug.

> Update interface to use a wrapper for various clock types
> ---------------------------------------------------------
>
>                 Key: CASSANDRA-1070
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1070
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Johan Oskarsson
>            Assignee: Sylvain Lebresne
>             Fix For: 0.7
>
>         Attachments: 0001-Introduces-wrapper-for-clock-types-generalizing-time.patch,
0001-v2-Introduces-wrapper-for-clock-types-generalizing-time.patch, 0001-v4-Introduces-wrapper-for-clock-types-generalizing-time.patch,
0001-v5-Introduces-wrapper-for-clock-types-generalizing-time.patch, 0001-v6-Introduces-wrapper-for-clock-types-generalizing-time.patch,
0002-Update-unit-tests.patch, 0002-v6-Update-unit-tests.patch, 0003-Update-System-tests.patch,
0003-v6-Update-System-tests.patch
>
>
> In the latest CASSANDRA-580 patch the timestamp used for conflict resolution has been
replaced by a Clock object that can contain either timestamp or a context byte array. That
change allows for other conflict resolution techniques to be used. 
> The change can be broken out and submitted here in order to make CASSANDRA-580 more manageable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message