Return-Path: Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: (qmail 67500 invoked from network); 17 Apr 2010 09:07:52 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 17 Apr 2010 09:07:52 -0000 Received: (qmail 23250 invoked by uid 500); 17 Apr 2010 09:07:52 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 23187 invoked by uid 500); 17 Apr 2010 09:07:50 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 23179 invoked by uid 99); 17 Apr 2010 09:07:49 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 17 Apr 2010 09:07:49 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 17 Apr 2010 09:07:47 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o3H97PX4012042 for ; Sat, 17 Apr 2010 05:07:25 -0400 (EDT) Message-ID: <4342196.24121271495245483.JavaMail.jira@thor> Date: Sat, 17 Apr 2010 05:07:25 -0400 (EDT) From: "Erick Tryzelaar (JIRA)" To: commits@cassandra.apache.org Subject: [jira] Updated: (CASSANDRA-994) re-organize endpointsnitch implementations In-Reply-To: <14500987.14181271439985377.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/CASSANDRA-994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Tryzelaar updated CASSANDRA-994: -------------------------------------- Attachment: 0001-Rename-internal-uses-of-EndPoint-to-Endpoint.patch 0002-Rename-internal-uses-of-endPoint-to-endpoint.patch 0003-Rename-files-named-EndPoint-to-Endpoint.patch The first 3 of 4 patches that implements this. These in particular change the spelling of an end point to endpoint or Endpoint, not endPoint or EndPoint. > re-organize endpointsnitch implementations > ------------------------------------------ > > Key: CASSANDRA-994 > URL: https://issues.apache.org/jira/browse/CASSANDRA-994 > Project: Cassandra > Issue Type: Task > Affects Versions: 0.7 > Reporter: Jonathan Ellis > Assignee: Erick Tryzelaar > Fix For: 0.7 > > Attachments: 0001-Rename-internal-uses-of-EndPoint-to-Endpoint.patch, 0002-Rename-internal-uses-of-endPoint-to-endpoint.patch, 0003-Rename-files-named-EndPoint-to-Endpoint.patch > > > I think the EPS implementations should look like this: > IEndPointSnitch: rename to IEndpointSnitch (lowercase P), otherwise fine as it is > SimpleSnitch: new default snitch. Implement IEPS directly, with sorting as no-ops. > AbstractEndpointSnitch: rename to AbstractRackAwareSnitch; replace isOnSameRack and isInSameDataCenter with getRack and getDatacenter (replacing getLocation). > EndPointSnitch: rename to RackInferringSnitch > PropertyFileEndpointSnitch: rename to PropertyFileSnitch, move from contrib to src > DatacenterEndpointSnitch: remove (redundant wrt PFS). "quorum factor per DC" needs to go in the ReplicationStrategy, not the snitch. > The patch sequence looks like: > 01: perform renames of IEPS, AES, EPS, and PFES > 02: add SS and make method changes to ARAS [was AES] > Separate ticket: DatacenterReplicationStrategy code changes -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira