Return-Path: Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: (qmail 74630 invoked from network); 19 Apr 2010 15:55:14 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 19 Apr 2010 15:55:14 -0000 Received: (qmail 81667 invoked by uid 500); 19 Apr 2010 15:55:14 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 81648 invoked by uid 500); 19 Apr 2010 15:55:14 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 81640 invoked by uid 99); 19 Apr 2010 15:55:14 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Apr 2010 15:55:14 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Apr 2010 15:55:12 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o3JFso8n001748 for ; Mon, 19 Apr 2010 11:54:50 -0400 (EDT) Message-ID: <20245756.14511271692490527.JavaMail.jira@thor> Date: Mon, 19 Apr 2010 11:54:50 -0400 (EDT) From: "Brandon Williams (JIRA)" To: commits@cassandra.apache.org Subject: [jira] Commented: (CASSANDRA-999) add crc for commitlogheader In-Reply-To: <8945202.2941271636210120.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/CASSANDRA-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858567#action_12858567 ] Brandon Williams commented on CASSANDRA-999: -------------------------------------------- Let's also add a filename or file magic check, so that if someone points their CL dir to a directory full of crap we don't OOM trying to process the crap. > add crc for commitlogheader > --------------------------- > > Key: CASSANDRA-999 > URL: https://issues.apache.org/jira/browse/CASSANDRA-999 > Project: Cassandra > Issue Type: Improvement > Reporter: Jonathan Ellis > Assignee: Jonathan Ellis > Fix For: 0.7 > > > We CRC the mutations in the commitlog as of 0.5, but not the header. (This is more important in 0.7 since the header contains CF id map and may change from segment to segment.) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.