cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-950) Cache BufferedRandomAccessFile.length
Date Tue, 06 Apr 2010 12:51:33 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853914#action_12853914
] 

Jonathan Ellis commented on CASSANDRA-950:
------------------------------------------

+1

(if you could fix the whitespace here on commit that would be great -- mixed tabs + spaces?)

+        else
+        {
+    		// opened as read only, file length is cached
+        	return fileLength;
+		}


> Cache BufferedRandomAccessFile.length
> -------------------------------------
>
>                 Key: CASSANDRA-950
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-950
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Johan Oskarsson
>         Attachments: CASSANDRA-950.patch, CASSANDRA-950.patch
>
>
> Profiling shows that BufferedRandomAccessFile.length is eating up an unexpected amount
of cpu. It believe it is the call through the "native barrier" that is causing it. We often
call the length method via is end of file when reading data. We can add caching of the file
length to avoid this call most times.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message