cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-699) Add (optional) expiration time for column
Date Fri, 09 Apr 2010 15:05:50 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855426#action_12855426
] 

Jonathan Ellis commented on CASSANDRA-699:
------------------------------------------

> However that made me remember one of the not so clean part of this code.
ExpiringColumn extends Column. I've done that because this has a few
advantages: it avoids a bit of code duplication; there is no needs for any
change in the few parts of the code where there is an explicit cast of an
IColumn to a Column; and in principle, it doesn't seems completely crazy to
have ExpiringColumn inherit from Column.
But it has the drawback that ExpiringColumn inherits of the isMarkedForDelete
field of Column but never uses it.

Did you look into extracting the common parts into AbstractColumn, that both C and EC could
inherit from?

> Add (optional) expiration time for column 
> ------------------------------------------
>
>                 Key: CASSANDRA-699
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-699
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>             Fix For: 0.7
>
>         Attachments: 0001-Add-new-ExpiringColumn-class-v2.patch, 0002-Add-TTL-support-to-cassandra.thrift.patch,
0003-Plug-thrift-TTL-addition-to-ExpiringColumn.patch, 0004-Update-test_server-for-insert-changes-and-add-simple.patch,
add_expiring_column_0.6-rc1.diff, add_expiring_column_0.6beta2.diff, modify_test_0.6-rc1.diff,
modify_test_0.6beta2.diff, thrift_API_change_0.6-rc1.diff, thrift_API_change_0.6beta2.diff
>
>
> Allow to attach an expiration time to a column. 
> An expired column would act much like a 'markedForDelete' one. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message