cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Blose (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-714) remove keyspace argument from thrift methods
Date Wed, 21 Apr 2010 22:12:51 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859549#action_12859549
] 

Todd Blose commented on CASSANDRA-714:
--------------------------------------

I'll take a look at the hadoop issue.

I removed the access level check because it requires authenticating to a keyspace that does
not exist yet. 

checkLoginAuthorized checks to see if a keyspace is present to prevent the other thrift calls
from being executed without a keyspace being associated with the session, but I guess if login
is always called before trying to add the keyspace, then this wouldn't be an issue (though
it's weird logging into a non-existent keyspace)

Let me know if you find any other issues, and I'll address these tonight.

> remove keyspace argument from thrift methods
> --------------------------------------------
>
>                 Key: CASSANDRA-714
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-714
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Eric Evans
>            Assignee: Todd Blose
>             Fix For: 0.7
>
>         Attachments: 0001-CASSANDRA-714.-rm-keyspace-argument-from-thrift-meth.patch,
CASSANDRA-714.patch, CASSANDRA-714.patch.new, CASSANDRA-714_python_tests.patch, CASSANDRA-714_server.patch,
CASSANDRA-714_thrift_def.patch
>
>
> With the completion of CASSANDRA-547, the keyspace can be specified as part of the login
and stored in a thread-local. This will allow us to remove the wasteful and redundant mandatory
keyspace argument on all of the other rpc methods.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message