cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Zlatanov (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (CASSANDRA-835) ThriftGlue should have KeyRange, Mutation, and Deletion creation helper methods to make life easier for users
Date Thu, 04 Mar 2010 15:08:27 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841318#action_12841318
] 

Ted Zlatanov edited comment on CASSANDRA-835 at 3/4/10 3:07 PM:
----------------------------------------------------------------

Actually with the new chained Thrift methods ThriftGlue can be obsoleted, as for example in
CassandraServer:

KeyRange range = new KeyRange().setStart_key(start_key).setEnd_key(finish_key).setCount(maxRows);

So as far as I'm concerned this is not an issue.

      was (Author: tzz):
    Actually with the new chained Thrift methods this is not an issue and ThriftGlue can be
obsoleted, as for example in CassandraServer:

KeyRange range = new KeyRange().setStart_key(start_key).setEnd_key(finish_key).setCount(maxRows);

So as far as I'm concerned this is not an issue.
  
> ThriftGlue should have KeyRange, Mutation, and Deletion creation helper methods to make
life easier for users
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-835
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-835
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Ted Zlatanov
>            Priority: Minor
>         Attachments: 0001-CASSANDRA-835.patch
>
>
> ThriftGlue doesn't have any helper methods for KeyRange, Mutation, and Deletion.  Those
should be provided since we can expect API users to need them.
> I propose:
> Mutation createMutation(Deletion d)
> Mutation createMutation(Column c)
> Mutation createMutation(SuperColumn c)
> Deletion createDeletion(byte[] supercolumnName)
> Deletion createDeletion(SlicePredicate predicate)
> KeyRange createKeyRange_Key(String startKey, String endKey)
> KeyRange createKeyRange_Token(String startToken, String endToken)
> I don't know if it's useful to mix keys and tokens in the key range.
> The patch is trivial so let me know if I should put it together.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message