cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Johan Oskarsson (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-917) Refactor QueryFilter so callers don't have to care about special-casing supercolumn paths
Date Sun, 28 Mar 2010 11:40:27 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850658#action_12850658
] 

Johan Oskarsson commented on CASSANDRA-917:
-------------------------------------------

A great improvement. A couple of issues/details:

* It would be good to have some more javadoc, for example on the static methods in QueryFilter
that developers will often have to use to get the various filter types.

* Minor detail: a lot of the classes that had the direct dependency on SliceQueryFilter/NamesQueryFilter
removed still have them in the import list.

* On my machine this system test fails (and it doesn't fail on trunk):

FAIL: system.test_thrift_server.TestMutations.test_time_uuid
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Library/Python/2.6/site-packages/nose-0.11.3-py2.6.egg/nose/case.py", line 186, in
runTest
    self.test(*self.arg)
  File "/Users/johan/Documents/workspace/cassandra-917/test/system/test_thrift_server.py",
line 196, in test_time_uuid
    assert slice == [Column(L[-1].bytes, 'value499', 499)], slice
AssertionError: [Column(timestamp=499, name='\xa7\xdb]\x9c:S\x11\xdf\x8d\x94d\xb9\xe8\xca\x04\xb4',
value='value499'), Column(timestamp=494, name='\xa7\xd7z\xd8:S\x11\xdf\x8d\x94d\xb9\xe8\xca\x04\xb4',
value='value494'), Column(timestamp=483, name='\xa7\xcf\xf9f:S\x11\xdf\x8d\x94d\xb9\xe8\xca\x04\xb4',
value='value483'), Column(timestamp=472, name='\xa7\xc4\x0c\x1e:S\x11\xdf\x8d\x94d\xb9\xe8\xca\x04\xb4',
value='value472')]


> Refactor QueryFilter so callers don't have to care about special-casing supercolumn paths
> -----------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-917
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-917
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 917-v2.txt, 917.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message